Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: send raw tx #58

Open
amanusk opened this issue Jan 1, 2024 · 2 comments
Open

Feature request: send raw tx #58

amanusk opened this issue Jan 1, 2024 · 2 comments

Comments

@amanusk
Copy link

amanusk commented Jan 1, 2024

As a complementary feature to #57, it would be great to have the option to broadcast a raw tx by only providing a network/RPC provider.
Useful if you want to modify data created by --raw-tx manually, and then only use starkli as a convenient interface to broadcast the raw JSON data (e.g. by supplying a file or a string)

@xJonathanLEI
Copy link
Owner

This feature makes a lot of sense once #57 is implemented. However, regarding the modify data created by `--raw-tx` manually part I'm not so sure.. If you manually modify data, the signature would change right? Then you cannot really broadcast it anymore.

@amanusk
Copy link
Author

amanusk commented Jan 4, 2024

Good point, in our usecase we indeed modified both data and signature. I still think this is useful to have this option as an easy way to send (or resend) raw txs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants