Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to codebase #298

Open
alex-96-eng opened this issue Mar 29, 2024 · 2 comments
Open

Add type hints to codebase #298

alex-96-eng opened this issue Mar 29, 2024 · 2 comments

Comments

@alex-96-eng
Copy link

Is this in scope and worth the effort? If so I can pick it up

@alex-96-eng alex-96-eng changed the title Typehinting codebase Add type hints to codebase Mar 29, 2024
@kmkmjhyiiiu
Copy link

Why not to just add it and make a PR, others will confirm if it is essential.

However, of course. It also makes sense about not wasting precious time on smth.

@alex-96-eng
Copy link
Author

Exactly. The codebase although small has quite a lot of dense handlers. I didn't want to spend the effort if the PR is out of scope and ultimately has no value from the perspective of the maintainers (if it was valuable they would have already added).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants