Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS projects with RuntimeIdentifiers don't build correctly #19262

Open
rolfbjarne opened this issue Oct 19, 2023 · 1 comment · May be fixed by #20799
Open

iOS projects with RuntimeIdentifiers don't build correctly #19262

rolfbjarne opened this issue Oct 19, 2023 · 1 comment · May be fixed by #20799
Labels
bug If an issue is a bug or a pull request a bug fix
Milestone
.NET 10

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Oct 19, 2023 •
edited
Loading

We should test an iOS project with RuntimeIdentifiers (and not RuntimeIdentifier) and see if it works with our tooling.

Potential known issues:

Example 1: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1901519

Error:

error : MessagingRemoteException: An error occurred on client Build190102 while executing a reply for topic xvs/build/1.9.0.102/execute-task/appname/8d34b29002fMergeAppBundles
error : AggregateException: One or more errors occurred. (The method or operation is not implemented.)

Looks like the MergeAppBundles task doesn't support being executed remotely.

Example 2: #19141 (comment)

Looks like VSMac doesn't quite work with RuntimeIdentifiers?

Example 3: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2036400

Error:

MessagingRemoteException: An error occurred on client Build1728053 while executing a reply for topic xvs/build/17.2.8053/execute-task/{AppName}/b23186c002fWriteAppManifest

Looks like the WriteAppManifest task doesn't support being executed remotely.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Oct 19, 2023
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Oct 19, 2023
@cullub
Copy link

cullub commented May 1, 2024

This issue also caused the following error message for me:

MessagingRemoteException: An error occurred on client Build1728053 while executing a reply for topic xvs/build/17.2.8053/execute-task/{AppName}/b23186c002fWriteAppManifest
ArgumentNullException: Value cannot be null.
Parameter name: path2

And replacing the <RuntimeIdentifiers> (plural) tag with <RuntimeIdentifier> (singular) tags fixed the issue.

@rolfbjarne rolfbjarne mentioned this issue May 31, 2024
Closed
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jun 20, 2024
@rolfbjarne
[msbuild] Don't support RuntimeIdentifiers for Hot Restart.
7af041c 
There's no need to support `RuntimeIdentifiers` (plural) for Hot Restart
(because we don't have any scenarios where multiple runtime identifiers
applies to iOS; a single runtime identifier can always be used).

Adding support would make our code base more complex, so just avoid it by
showing an early error if someone tries (which is likely to be accidental
anyways).

This way we show an actionable error message for a scenario customers will
probably be confused about (because the build would fail in rather
inexplicable ways) if they run into it.

Partial fix for xamarin#19262.
@rolfbjarne rolfbjarne mentioned this issue Jun 20, 2024
Merged
rolfbjarne added a commit that referenced this issue Jul 1, 2024
@rolfbjarne
[msbuild] Don't support RuntimeIdentifiers for Hot Restart. (#20750)
a28cf64 
There's no need to support `RuntimeIdentifiers` (plural) for Hot Restart
(because we don't have any scenarios where multiple runtime identifiers
applies to iOS; a single runtime identifier can always be used).

Adding support would make our code base more complex, so just avoid it by
showing an early error if someone tries (which is likely to be accidental
anyways).

This way we show an actionable error message for a scenario customers will
probably be confused about (because the build would fail in rather
inexplicable ways) if they run into it.

Partial fix for #19262.
@rolfbjarne rolfbjarne linked a pull request Jul 1, 2024 that will close this issue
Draft
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
.NET 10
2 participants
@rolfbjarne @cullub