Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty translations are not rendered #183

Open
msucevan opened this issue Jul 19, 2024 · 1 comment
Open

Empty translations are not rendered #183

msucevan opened this issue Jul 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@msucevan
Copy link

The issue is because of this PR.

The behaviour in Laravel is to render the key when the provided translation is empty or not found... With this change the package is not working anymore with the current Laravel business logic this can lead to some incongruences.
@msucevan msucevan changed the title Empty translations are rendered Empty translations not are rendered Jul 19, 2024
@xiCO2k
Copy link
Owner

xiCO2k commented Jul 25, 2024

Thanks for letting me know, will check.

@xiCO2k xiCO2k added the bug Something isn't working label Jul 25, 2024
@msucevan msucevan changed the title Empty translations not are rendered Empty translations are not rendered Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiCO2k @msucevan