Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device ID Field to WRP SimpleEvent and RequestResponse #53

Open
kristinapathak opened this issue Aug 7, 2020 · 1 comment
Open
Labels
device ID parsing enhancement New feature or request

Comments

@kristinapathak
Copy link
Contributor

kristinapathak commented Aug 7, 2020

type SimpleEvent struct {

The Source of a SimpleEvent is no longer always the device ID, so to provide an easy way to understand what device the event is for, we will add a separate field for that. The field should also be added to the general wrp.Message struct and the RequestResponse struct, so that Device ID can be added for responses.

This update will match the new spec after xmidt-org/docs#51 is fixed.

@kristinapathak
Copy link
Contributor Author

The new field should also be added everywhere applicable, such as the translation of struct to headers:

func AddMessageHeaders(h http.Header, m *wrp.Message) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device ID parsing enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant