-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non browser compatible node-module required #23
Comments
Could you provide a reproducible example as a github repo (I'm too lazy to configure rollup)? |
Could you please check if the issue is gone with the latest published version of Ololog? |
Sorry for not replying, mix of lazyness and busy on my side. I will test today! |
So I tested the changes, I got the exact same error
to be sure it's new version, I looked into node_modules at the package.json version So I just made a reproduceable example repo
This you can test out here https://github.com/hlolli/ololog_bug using the command |
Thank you for the repro, I'll look into it in the coming days. |
For reasons too long to explain here, I can't include browser compatible polyfills for built-in nodejs modules.
So when I'm compiling targeting the browser with rollup I'm getting
perhaps some easy
isBrowser
will fix this. I'm also sure that it should be possible to findrequire ('util').inspect
browserified (using built-in modules if in nodejs env).The text was updated successfully, but these errors were encountered: