Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish compiled wheels for Windows #42

Open
scottgigante opened this issue Oct 24, 2019 · 4 comments
Open

Publish compiled wheels for Windows #42

scottgigante opened this issue Oct 24, 2019 · 4 comments

Comments

@scottgigante
Copy link

Thanks for publishing precompiled wheels for Linux and MacOS. Would it be possible to publish wheels for Windows as well?

Thanks!

@masajiro
Copy link
Member

Since we understand Windows is an important OS for NGT, we are considering that. So far, we have no plan for that.

@scottgigante
Copy link
Author

Thank you for the update!

@ankane
Copy link
Contributor

ankane commented Feb 6, 2020

fwiw, I tried compiling NGT on Windows with GitHub Actions. I'm not very good at C++, but wanted to report my findings for others.

The following errors occurred:

  1. error C3646: '_mutex': unknown override specifier
  2. error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
  3. fatal error C1083: Cannot open include file: 'sys/time.h'
  4. fatal error C1083: Cannot open include file: 'unistd.h'
  5. fatal error C1083: Cannot open include file: 'pthread.h'

From what I can tell, 1 and 2 are likely smaller changes that will be compatible with Unix.

For 3, 4, and 5, there are some suggested approaches on Stack Overflow.

Overall, I imagine this would take some time.

Build code: https://github.com/ankane/ml-builds/blob/ngt-windows/.github/workflows/ngt-windows.yml
Full output: https://github.com/ankane/ml-builds/runs/429047982

(had to set -D UNIX=ON for it to build the library)

@paulbricman
Copy link

Windows support would be great! I'm trying to use NGT on a client-side app, so lacking Windows support is really a bummer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@ankane @scottgigante @paulbricman @masajiro and others