New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

img_set_pixel appears to be faulty #29

Open

ndevenish opened this issue May 15, 2021 · 1 comment

Contributor

ndevenish commented May 15, 2021

It looks like it's trying to check if the input x, y is out of range, but it actually checks that y is in range:

cbflib/src/img.c

Lines 2073 to 2078 in 5c31378

    
           if (x < 0              || 
        
               x >= img->size [0] || 
        
               y > 0              || 
        
               y <= img->size [1]) 
        
             return 0;

Owner

yayahjb commented May 15, 2021 via email

Looks like you have found a bug. Want to write and test the fix and submit a pull request?

On Sat, May 15, 2021 at 3:29 PM Nicholas Devenish ***@***.***> wrote: It looks like it's trying to check if the input x, y is *out* of range, but it actually checks that y is *in* range: https://github.com/yayahjb/cbflib/blob/5c31378d597fb1c6c543f3e372ff80042c600a52/src/img.c#L2073-L2078 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#29>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB6EANUBPBBKDIZ55LQNLTTN3DQJANCNFSM446FVJZA> .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment