Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we supposed to use 0.9.7? #60

Closed
ndevenish opened this issue Aug 20, 2022 · 2 comments
Closed

Are we supposed to use 0.9.7? #60

ndevenish opened this issue Aug 20, 2022 · 2 comments

Comments

@ndevenish
Copy link
Contributor

I'm left unsure if 0.9.7 is supposed to be used externally, or if it's just an internal/alpha partial release before something considered ready for production:

  • pycbf apparently un-regenerated (Procedure to regenerate pycbf? #59)
  • https://github.com/cbflib/cbflib is not updated (which my understanding was to be the new home)
  • The README still says 0.9.6:

    cbflib/README

    Lines 14 to 18 in 5232590

    CBFlib
    README
    Information for CBFlib 0.9.6 release of 4 December 2018
  • CBFlib.html still says 0.9.5:

    cbflib/doc/CBFlib.html

    Lines 111 to 115 in 5232590

    <b>An API for CBF/imgCIF<br />
    Crystallographic Binary Files with ASCII Support</b><br />
    Version 0.9.5<BR>
    27 April 2014<BR>
    rev 22 February 2015<br />
  • The official(?) web site http://www.bernstein-plus-sons.com/software/CBF/ still says 0.9.6
  • The CMakeLists.txt still says 0.9.6 (and tries to download the 0.9.6 test data):
    # Version 0.9.6 06 November 2018 #
  • The CBFlib internal version still says that it is 0.9.6 (Since this is the most important actual baked-in version number, this is possibly the biggest signal that I shouldn't be using 0.9.7):

    cbflib/include/cbf.h

    Lines 262 to 264 in 5232590

    #define CBF_VERS_MAJOR 0 /* For major interface/format changes */
    #define CBF_VERS_MINOR 9 /* For minor interface/format changes */
    #define CBF_VERS_RELEASE 6 /* For tweaks, bug-fixes, or development */
  • The github release page says "Initial CBFlib-0.9.7" whereas the previous release says "CBFlib-0.9.6 Production Release"
  • The branch https://github.com/yayahjb/cbflib/tree/CBFlib-0.9.7-devel on this repository is still actively under development
  • The github PR CBFlib 0.9.7 devel cbflib/cbflib#1 for development is unmerged but up-to-date with the CBFlib-devel branch, indicating that it is actively maintained

It is fine if this is the case - I am just unsure if I should put time into diagnosing the issues I'm having or whether I should just wait for a complete release!

@yayahjb
Copy link
Owner

yayahjb commented Aug 20, 2022 via email

@ndevenish
Copy link
Contributor Author

Okay, so we have to deal with things as they are for now. Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants