Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the service of DetaDrive #10

Open
yeikel16 opened this issue Jan 28, 2022 · 8 comments
Open

feat: implement the service of DetaDrive #10

yeikel16 opened this issue Jan 28, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yeikel16
Copy link
Owner

yeikel16 commented Jan 28, 2022

Deta Drive is a managed, secure and scalable file storage service in the Deta plataform.

@yeikel16 yeikel16 self-assigned this Jan 28, 2022
@yeikel16 yeikel16 added enhancement New feature or request help wanted Extra attention is needed labels Jan 28, 2022
@DonnC
Copy link

DonnC commented Mar 19, 2022

@yeikel16 thanks for this man and good work
Have been trying the deta drive and have started my own implementation also but glad to find this maybe we can work together

Do lemme know

@yeikel16
Copy link
Owner Author

@yeikel16 thanks for this man and good work Have been trying the deta drive and have started my own implementation also but glad to find this maybe we can work together

Do lemme know

I'm glad to know, your contribution would be very helpful, right now I'm quite busy with the university tests and I don't have much time. I would like to see what you have done and what we can do based on your previous experience with this feature.

I don't know if you are already familiar with the project, if you have any questions or suggestions, they are all welcome.

@DonnC
Copy link

DonnC commented Mar 19, 2022

Thanks i will put it together and reference it here as a public repo because i havent put it as a package yet
Will definitely do so

@DonnC
Copy link

DonnC commented Mar 20, 2022

@yeikel16 Wassup man
I have been running in app tests (not proper tests, might do this later) but its working for now
The only thing i havent done is chunked upload, for my use case i havent found its use but its needed

Here is the link deta drive dart

Havent published, i think its best we have 1 deta dart plugin

@yeikel16
Copy link
Owner Author

Thank you, as soon as I have some time I check your repository and tell you to start the implementation together from your code to the main package.

One of the things we have to keep in mind is that the deta package can be used by any HTTP client that is injected from the ClientDetaApi interface , either DioClientDetaApi or HttpClientDetaApi, then you have to find a middle point to find the best way to upload the files, I don't know if I explain myself ? Since each request packet (Dio / http) implements the way to upload files differently.

I would like to do more research on the subject to have more options when it comes to implementation, if you have any ideas or suggestions they are always welcome, thanks again.

@DonnC
Copy link

DonnC commented Mar 20, 2022

No problem, i have seen you had that implementation i will go through it again thoroughly and make the code use that same convention so that we give the flexibility on the library the user can use 👍

@yeikel16 yeikel16 pinned this issue Mar 21, 2022
yeikel16 added a commit that referenced this issue Mar 25, 2022
- implement `uploadFile` method
@yeikel16
Copy link
Owner Author

Hey @DonnC, I hope you are well in these times, I already checked your repository and your proposal seems interesting to me.
I have created the deta-drive branch to develop the new DetaDrive feature until it is stable.
On the part of the implementation in the dio_client_deta_api package there shouldn't be many problems, I've already tried the uploadFile method and everything works fine, however, the http_client_deta_api package needs to work a little more to implement the callbacks of onSendProgress and onReceiveProgress as these are not natively implemented by the http package itself.
Can you take the implementation part of the methods in the deta package and the fix in dio_client_deta_api ?
I'm going to take the http_client_deta_api part, I want to investigate more about handling files in requests, I've never worked with the http package before, and this would be a good way.

@DonnC
Copy link

DonnC commented Mar 25, 2022

Thanks man, i have seen the changes, that's good work
I will definitely find time to work on the remaining work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants