Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release persistent-template version 2.1.7 that supports ghc-8.0 #556

Closed
erikd opened this issue Apr 20, 2016 · 1 comment
Closed

Comments

@erikd
Copy link
Contributor

erikd commented Apr 20, 2016

Esqueleto still doesn't support persistent-2.5 but will build with ghc-8.0 if the upper bound on the base dependency is bumped (see prowdsponsor/esqueleto#135).

It would therefore be nice (and easy to do) to release a version of persistent-template that supports ghc-8.0.

If I checkout the persistent-template/2.1.6 tag as a branch I can then cherry pick commit 3adc3e6 which then builds and tests ok with both ghc-7.10 and ghc-8.0. I'd do a pull request, but I'm not sure how to do a pull request against something that is not a branch.

@erikd erikd changed the title Please release a version persistent-template version 2.1.7 that supports ghc-8.0 Please release persistent-template version 2.1.7 that supports ghc-8.0 Apr 20, 2016
snoyberg added a commit that referenced this issue Apr 20, 2016
@snoyberg
Copy link
Member

Awesome, done. Thanks for pushing these fixes all the way up the dependency tree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants