TypeScript preConversion doesn't consider error code or stderr output

[owickstrom]

The script used in the TypeScript preConvert stage doesn't:

• Consider the error code returned by tsc
• Output compilation errors to stderr

The existing script is (with line breaks):

TMP_IN=$(mktemp XXXXXXXXXX.ts);
TMP_OUT=$(mktemp XXXXXXXXXX.js);
cat /dev/stdin > ${TMP_IN} && tsc --out ${TMP_OUT} ${TMP_IN} && cat ${TMP_OUT};
rm ${TMP_IN} && rm ${TMP_OUT}

To improve on the situation the script could:

• Use traps to always remove temp files, and have the tsc command as the last one, thus returning tsc's error code
• Redirect the output from stdout to stderr

Something like this (I've tested in this in a custom ShakespeareSettings value):

TMP_IN=$(mktemp XXXXXXXXXX.ts);
TMP_OUT=$(mktemp XXXXXXXXXX.js);
trap "rm ${TMP_OUT};" EXIT;
trap "rm ${TMP_IN};" EXIT;
cat /dev/stdin > ${TMP_IN} && tsc --out ${TMP_OUT} ${TMP_IN} 1>&2 && cat ${TMP_OUT}

If this sounds good I can submit a PR.

Thanks for this library, by the way! 🙂

[snoyberg]

I'm not familiar with the TypeScript code, but this sounds reasonable. @gregwebs do you have any input?

[gregwebs]

sounds good to me