Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "perfect" waking through intermediate wakers #21

Open
7 of 13 tasks
yoshuawuyts opened this issue Nov 4, 2022 · 0 comments
Open
7 of 13 tasks

Implement "perfect" waking through intermediate wakers #21

yoshuawuyts opened this issue Nov 4, 2022 · 0 comments
Labels
performance computer goes brrrrr

Comments

@yoshuawuyts
Copy link
Owner

yoshuawuyts commented Nov 4, 2022 •
edited
Loading

Instead of each poll call being O(N) in time, it should be O(1) in time, by tracking which futures have been woken on each iteration, and only waking those.

This acts as a guard against faulty manually implemented futures which don't have a fast return path in the case the wake is a no-op. #8 is a first attempt at such a patch, but needs more work to finish up.

Tasks

Priority

Secondary

  • Join for Vec
  • Join for Array
  • Join for tuple
  • Race for Vec
  • Race for Array
  • Race for tuple

Eventually

  • TryJoin for Vec
  • TryJoin for Array
  • TryRace for Vec
  • TryRace for Array
@yoshuawuyts yoshuawuyts changed the title Keep track of woken futures Implement "perfect" waking through intermediate wakers Nov 7, 2022
@yoshuawuyts yoshuawuyts mentioned this issue Nov 8, 2022
Closed
@yoshuawuyts yoshuawuyts added enhancement New feature or request performance computer goes brrrrr and removed enhancement New feature or request labels Nov 9, 2022
This was referenced Nov 14, 2022
Closed
Merged
@yoshuawuyts yoshuawuyts pinned this issue Nov 15, 2022
This was referenced Nov 18, 2022
Merged
Merged
Swatinem added a commit to Swatinem/futures-concurrency that referenced this issue Nov 30, 2022
@Swatinem
Implement perfect waking for array/vec Join
c3762c8 
Tries to implement yoshuawuyts#21 for array and vec Join.
Swatinem added a commit to Swatinem/futures-concurrency that referenced this issue Nov 30, 2022
@Swatinem
Implement perfect waking for array/vec Join
dba2e92 
Tries to implement yoshuawuyts#21 for array and vec Join.
@Swatinem Swatinem mentioned this issue Nov 30, 2022
Merged
Swatinem added a commit to Swatinem/futures-concurrency that referenced this issue Nov 30, 2022
@Swatinem
Implement perfect waking for array/vec Join
d925dca 
Tries to implement yoshuawuyts#21 for array and vec Join.
@yoshuawuyts yoshuawuyts mentioned this issue Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance computer goes brrrrr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yoshuawuyts