Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issues about button disappearing in new file viewer version of Github #2

Open
ericvd-ucb opened this issue May 10, 2023 · 8 comments

Comments

@ericvd-ucb
Copy link

For me the experience was that button disappeared, when I was previewing a new version of Github

@balajialg
Copy link
Collaborator

balajialg commented May 18, 2023

Yes +100 to @ericvd-ucb's comment as this new and forced global navigation update in Github is proving to be a huge pain point for using this nbgitpuller extension @yuvipanda.

Snapshot 1:
image

Snapshot 2:
image

The nbgitpuller button disappears when navigated to the file browser as seen in the snapshot 2 making this plugin unusable across Firefox and Chrome. We need to fix this before the start of summer classes or else we will be going back by 2 years to generate links in the old-fashioned way. I am not sure what the fix here is but your inputs here will be a huge value add.

I gave this feedback in the comments section of the Global navigation beta feedback page but not sure whether anyone would care.

@pamelafox
Copy link
Collaborator

Sent fix in #5

@yuvipanda
Copy link
Owner

Thanks a lot, @pamelafox! I've tagged a v2, and updated the firefox extension - it is awaiting review. I'll do the same for Chrome

@yuvipanda
Copy link
Owner

I've submitted the extension to Chrome store for review as well!

@balajialg
Copy link
Collaborator

Wow, that's awesome @pamelafox and @yuvipanda! Super excited about this fix :)

@balajialg
Copy link
Collaborator

Firefox extension is updated (Chrome extension is not yet updated) and I can test this fix. Thanks @pamelafox for unblocking us with this fix.

image

@balajialg
Copy link
Collaborator

balajialg commented Jul 14, 2023

@pamelafox Your point about removing this extension's dependency on Github makes complete sense. I am running into issues such as this on a regular basis wrt specific repositories.
image

@balajialg
Copy link
Collaborator

balajialg commented Aug 11, 2023

@pamelafox @ericvd-ucb Seems like the nbgitpuller plugin is no longer visible when navigated to the specific ipynb file.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants