Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

异常并未真正处理, 可能导致数据丢失 #60

Open
thundertrick opened this issue Dec 17, 2018 · 1 comment
Open

异常并未真正处理, 可能导致数据丢失 #60

thundertrick opened this issue Dec 17, 2018 · 1 comment

Comments

@thundertrick
Copy link

MigrationHelper.java 中大量使用 try catch 结构捕获异常, 但是捕获后仅输出了异常日志, 没有真正意义上地处理异常. 这会埋下不少隐患.

随便举个例子, 比如generateTempTables 时, 哪怕并未成功创建临时表, 迁移依然不会终止, 后续的删除数据库操作仍然会执行, 这样就导致了老数据的遗失.

有计划处理一下类似隐患吗?
@thundertrick thundertrick changed the title 异常处理 异常并未真正处理, 可能导致数据丢失 Dec 17, 2018
@woodstream
Copy link

过去了那么久了，我还是想问，你怎么处理了？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thundertrick @woodstream