Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Oh-my-zsh plugins that use caching don't work #321

Open
2 of 3 tasks
fireboy1919 opened this issue Nov 1, 2024 · 2 comments
Open
2 of 3 tasks

[bug]: Oh-my-zsh plugins that use caching don't work #321

fireboy1919 opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. triage 📑 The issue is awaiting investigation.

Comments

@fireboy1919
Copy link

Environment

Linux

Reproduction steps

1.   Install a oh-my-zsh plugin that uses caching.  E.g. docker and last-working-dir

2.  Try using them.  In the case of last-working-dir, change directories.
   In the case of docker, just loading the prompt produces an error.

Expected behavior

They should work as expected.

Current behavior

The cache directory isn't defined, so the errors manifest as trying to save/load from a root directory.

Code snippet

zi wait lucid for
OMZP::docker
OMZP::last-working-dir

Additional information

I managed to fix this by adding this:
mkdir -p ~$HOME/.cache/zi
ZSH_CACHE_DIR="${XDG_CACHE_HOME:-$HOME/.cache}/zi"

This is not a problem in the original zinit, so this is a regression.

Obviously the solution is fairly simple: add a default cache dir variable when loading anything that comes from OMZP.

Self-service

  • I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

Are you familiar with the Contributor Covenant Code of Conduct?

Contact Details

[email protected]

@fireboy1919 fireboy1919 added bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. triage 📑 The issue is awaiting investigation. labels Nov 1, 2024
Copy link

github-actions bot commented Dec 2, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale 👻 No activity for quite some time. label Dec 2, 2024
@fireboy1919
Copy link
Author

Is this project just dead? This is a pretty simple bug to fix.

@github-actions github-actions bot removed the stale 👻 No activity for quite some time. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. triage 📑 The issue is awaiting investigation.
Projects
None yet
Development

No branches or pull requests

2 participants