Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Consider adding a macro for defining db commands #52

Open
dryewo opened this issue May 11, 2016 · 3 comments
Open

Consider adding a macro for defining db commands #52

dryewo opened this issue May 11, 2016 · 3 comments

Comments

@dryewo
Copy link
Contributor

dryewo commented May 11, 2016

(defmacro defquery-hystrix-commands [filename]
  `(do
     (defqueries ~filename)
     (generate-hystrix-commands)))
(defquery-hystrix-commands "db/queries.sql")
@prayerslayer
Copy link
Contributor

This sounds like a good idea.

@dryewo
Copy link
Contributor Author

dryewo commented May 14, 2016

Also, what about making the cmd- prefix explicit?

(defquery-hystrix-commands "cmd-" "db/queries.sql")

@LappleApple
Copy link

Hey @dryewo, can we close this issue? It dates back to May 2016.

Or, we could add a "Help Wanted" label.

@Otann Otann added this to the 2.1 or later milestone Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants