Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Docker image building doesn't work out of the box when using project template #77

Open
immoh opened this issue Aug 18, 2016 · 2 comments
Milestone

Comments

@immoh
Copy link
Contributor

immoh commented Aug 18, 2016

There's a problem in building docker image when using project template:

  • lein-scm-source creates scm-source.json in target dir. In project.clj target-path is set to target/%s so the location of the file is something like target/base+system+user+dev/scm-source.json
  • Dockerfile expects scm-source.json to be in the root of the project

I guess the obvious fix is to change lein-scm-source to generate in project root instead, or make it configurable and preconfigure it in the template. I am happy to provide a PR if you think this is the correct fix.

@PetrGlad
Copy link
Contributor

This is more a ticket for lein-scm-source I think (so it can generate .scm in current dir). Alternatively Dockerfile can be generated on demand but It looks like unnecessarily complex solution.

@immoh
Copy link
Contributor Author

immoh commented Sep 16, 2016

Another way to fix this (suggested by @dryewo): modify template project.clj to include alias scm-source for lein with-profile uberjar scm-source. Then the file would be generated in target/uberjar and we can change the path in Dockerfile to target/uberjar/scm-source.json.

@Otann Otann added this to the 2.0 Release milestone Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants