Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Do not use undocumented Clojure features in template project #78

Open
PetrGlad opened this issue Aug 18, 2016 · 1 comment
Open

Do not use undocumented Clojure features in template project #78

PetrGlad opened this issue Aug 18, 2016 · 1 comment
Milestone

Comments

@PetrGlad
Copy link
Contributor

Generated project.clj uses undocumented #= reader macro. I would suggest to use enclosing let instead, use hard-code some value or, better yet, make it a template's parameter (since current code makes too many assumptions about environment).

let version would look like

(let [docker-image-name (some-> (str (System/getenv "DEFAULT_DOCKER_REGISTRY") "/")
                                                     "example_team/maratus"))]
  (defproject ...
    ))

BTW, why (str "/") is needed in generated project.clj file?

@LappleApple
Copy link

Hey @dryewo, do you agree? If so, maybe @PetrGlad can work on this, or we can add a Help Wanted label?

@Otann Otann added this to the 2.0 Release milestone Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants