Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_encoding: Remove dependency on byteorder crate #1560

Open
str4d opened this issue Oct 7, 2024 · 0 comments
Open

zcash_encoding: Remove dependency on byteorder crate #1560

str4d opened this issue Oct 7, 2024 · 0 comments

Comments

@str4d
Copy link
Contributor

str4d commented Oct 7, 2024

use byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};

We currently rely on the ReadBytesExt and WriteBytesExt traits, which are built around std::io and thus require the std feature flag of byteorder. This makes the zcash_encoding crate incompatible with no-std environments (even if they support alloc).

We should move away from the byteorder crate in favour of the parsing methods on native types (like u64::from_le_bytes), which have been in Rust since 1.32 (well below our MSRV for zcash_encoding of 1.56.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant