Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the Sapling proving and verifying APIs #145

Open
str4d opened this issue Jan 15, 2019 · 1 comment
Open

Add tests for the Sapling proving and verifying APIs #145

str4d opened this issue Jan 15, 2019 · 1 comment

Comments

@str4d
Copy link
Contributor

str4d commented Jan 15, 2019

The Sapling logic for proving and verifying was refactored into the zcash_proofs crate in zcash/librustzcash#30. We should add tests!

The tests themselves should be pretty straightforward. However, we can't assume that the test runner has the mainnet Sapling parameters, so we probably want to generate fake parameters on-the-fly (if this is not too complex or slow to do in a test).

@str4d
Copy link
Contributor Author

str4d commented Jan 15, 2019

I added the "good first issue" label because this would be a good chance for someone new to learn how parameter generation works. It's definitely a larger chunk of work than other issues with the same label.

CryptoForge referenced this issue in CryptoForge/librustzcash Mar 3, 2019
@nuttycom nuttycom transferred this issue from zcash/librustzcash Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant