Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale comments about bit order in circuit/sapling/mod.rs #88

Open
daira opened this issue Aug 24, 2018 · 1 comment
Open

Stale comments about bit order in circuit/sapling/mod.rs #88

daira opened this issue Aug 24, 2018 · 1 comment
Labels
to librustzcash repo

Comments

@daira
Copy link
Contributor

daira commented Aug 24, 2018

https://github.com/zcash-hackworks/sapling-crypto/blob/21084bde2019c04bd34208e63c3560fe2c02fb0e/src/circuit/sapling/mod.rs#L467-L468

It is actually little-endian, as implemented in https://github.com/zcash-hackworks/sapling-crypto/blob/21084bde2019c04bd34208e63c3560fe2c02fb0e/src/circuit/sapling/mod.rs#L89-L93
@daira
Copy link
Contributor Author

daira commented Aug 24, 2018

There's another one here: https://github.com/zcash-hackworks/sapling-crypto/blob/21084bde2019c04bd34208e63c3560fe2c02fb0e/src/circuit/sapling/mod.rs#L264-L265

@daira daira changed the title Stale comment about bit order in circuit/sapling/mod.rs Stale comments about bit order in circuit/sapling/mod.rs Aug 24, 2018
stefandeml pushed a commit to stefandeml/sapling-crypto that referenced this issue Jul 5, 2019
@porcuquine
Use rusftmt-nightly 0.8.3. (zcash#88)
1409d9a 
* Use rusftmt-nightly 0.8.3.

* Fix rustfmt issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to librustzcash repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daira @str4d