New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract NoteCommit, MerkleCRH and MixingPedersenHash in the Spend circuit to match the spec #91

Open

daira opened this issue Oct 4, 2018 · 0 comments

Labels

to librustzcash repo

Contributor

daira commented Oct 4, 2018

From the QED-it report:

NoteCommit, MerkleCRH and MixingPedersenHash, while defined as separate functions in the spec, are defined only implicitly as unseparated code sections inside the Spend circuit, making analysis more difficult — we recommend to abstract them into distinct functions.

str4d added the to librustzcash repo label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment