Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether more code can be shared between TestConstraintSystem and ProvingAssignment #92

Open
daira opened this issue Oct 5, 2018 · 0 comments

Comments

@daira
Copy link
Contributor

daira commented Oct 5, 2018

From the QED-it report:

Testing is done with another implementation of ConstraintSystem
Description: ​TestConstraintSystem is used throughout testing while ProvingAssignment is used in proving, both implementing the ConstraintSystem trait. While our focus was testing constraints and cryptography, we’d like to note that this is also a potential location of danger - when adding constraints and allocating variables, there could be a different behaviour.

Note that both implementations (here and here) are very simple and short; they are essentially only keeping track of lists of auxiliary variables, inputs, and R1CS constraints. On the other hand, it does seem as though it might be possible to alleviate this concern for future reviews by sharing more code.

stefandeml pushed a commit to stefandeml/sapling-crypto that referenced this issue Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants