Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over zbchaos worker error handling #253

Open
Zelldon opened this issue Nov 23, 2022 · 0 comments
Open

Iterate over zbchaos worker error handling #253

Zelldon opened this issue Nov 23, 2022 · 0 comments
Assignees

Comments

@Zelldon
Copy link
Member

Zelldon commented Nov 23, 2022

Right now the zbchaos worker spawns a Zeebe worker and connects via the provided env vars to a camunda cloud cluster.

It registers for the zbchaos job type and will forward all further commands like verify readiness, via calling root again. https://github.com/zeebe-io/zeebe-chaos/blob/main/go-chaos/cmd/worker.go#L115

I feel there is one issue with this approach. Our commands call panic on error, which normally just exits the CLI with the error. In a case of a failure during executing the job worker we DON'T want to exit, we want to retry or fail the job.

This means we need to extract all logic used in the commands in separate functions to return errors, in the subCommands we can then call panic in our workers we have to handle the errors differently.

\cc @oleschoenburg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant