From 40ab62fb52b8dd32cc14a2bb7ce597048d7eab1f Mon Sep 17 00:00:00 2001 From: Christopher Zell Date: Mon, 18 Sep 2023 13:54:59 +0200 Subject: [PATCH 1/2] build: enable zeebe client logging --- core/src/main/resources/log4j2.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/resources/log4j2.xml b/core/src/main/resources/log4j2.xml index 1bfc7d55..84db7308 100644 --- a/core/src/main/resources/log4j2.xml +++ b/core/src/main/resources/log4j2.xml @@ -18,6 +18,7 @@ + From 9e5d58f93b83ed9fd46cfa0d469d159d1bef23b1 Mon Sep 17 00:00:00 2001 From: Christopher Zell Date: Mon, 18 Sep 2023 13:55:22 +0200 Subject: [PATCH 2/2] refactor: add more logs on JobHandlers --- .../handler/JobHandlerWithEnrichedLogger.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/io/zeebe/clustertestbench/handler/JobHandlerWithEnrichedLogger.java b/core/src/main/java/io/zeebe/clustertestbench/handler/JobHandlerWithEnrichedLogger.java index 7b4b9770..4d71de9a 100644 --- a/core/src/main/java/io/zeebe/clustertestbench/handler/JobHandlerWithEnrichedLogger.java +++ b/core/src/main/java/io/zeebe/clustertestbench/handler/JobHandlerWithEnrichedLogger.java @@ -5,6 +5,8 @@ import io.camunda.zeebe.client.api.worker.JobHandler; import java.util.List; import java.util.Map; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.slf4j.MDC; /** @@ -12,7 +14,7 @@ * activated job. */ public final class JobHandlerWithEnrichedLogger implements JobHandler { - + private static final Logger LOG = LoggerFactory.getLogger(JobHandlerWithEnrichedLogger.class); private final JobHandler delegate; public JobHandlerWithEnrichedLogger(final JobHandler delegate) { @@ -22,8 +24,14 @@ public JobHandlerWithEnrichedLogger(final JobHandler delegate) { @Override @SuppressWarnings("unused") public void handle(final JobClient client, final ActivatedJob job) throws Exception { + LOG.debug("Start handling of job {}", job.getKey()); try (final var loggingEnricher = new LoggingEnricher(job)) { delegate.handle(client, job); + } catch (final Exception ex) { + LOG.error("Handling of job {} failed, with {} ", job.getKey(), ex.getMessage(), ex); + throw ex; + } finally { + LOG.debug("Completed handling of job {}", job.getKey()); } } @@ -78,7 +86,7 @@ private void putVariableInMDCIfExists(final Map variables, final final String value; if (variable == null) { value = null; - } else if (variable instanceof String variableString) { + } else if (variable instanceof final String variableString) { value = variableString; } else { value = String.valueOf(variable);