Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: nrf54h: gpd: use callback to fetch nrfs async result #80819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Nov 4, 2024

Busy-waiting for the result of the nrfs service calls can stall, so let's use a callback that flags a semaphore instead. Since the API is supposed to be callable in the context of pre-kernel, fallback to busy-wait on that scenario.

Fixes #81057

@gmarull gmarull added the bug The issue is a bug, or the PR is fixing a bug label Nov 4, 2024
@gmarull gmarull marked this pull request as ready for review November 4, 2024 11:00
@gmarull gmarull added this to the v4.0.0 milestone Nov 4, 2024
@zephyrbot zephyrbot added the platform: nRF Nordic nRFx label Nov 4, 2024
soc/nordic/nrf54h/gpd/gpd.c Outdated Show resolved Hide resolved
anangl
anangl previously approved these changes Nov 4, 2024
anangl
anangl previously approved these changes Nov 4, 2024
soc/nordic/nrf54h/gpd/gpd.c Show resolved Hide resolved
Busy-waiting for the result of the nrfs service calls can stall, so
let's use a callback that flags a semaphore instead. Since the API is
supposed to be callable in the context of pre-kernel, fallback to
busy-wait on that scenario.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@mmahadevan108
Copy link
Collaborator

@gmarull , we are only merging PR's that have an Issue linked to it. If this is needed for 4.0, kindly enter an Issue and link to this PR.

@gmarull
Copy link
Member Author

gmarull commented Nov 7, 2024

@gmarull , we are only merging PR's that have an Issue linked to it. If this is needed for 4.0, kindly enter an Issue and link to this PR.

@mmahadevan108 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soc: nrf54h: GPD service calls may stall
7 participants