Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate filename, but what? #127

Open
frederikhors opened this issue May 15, 2024 · 3 comments
Open

Duplicate filename, but what? #127

frederikhors opened this issue May 15, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@frederikhors
Copy link

I'm getting this error:

invalid Zip archive: Duplicate filename

but I cannot understand what is the file duplicated.

Is it possible to write the filename in the error?

@frederikhors frederikhors added the bug Something isn't working label May 15, 2024
@Pr0methean Pr0methean added the good first issue Good for newcomers label May 16, 2024
@Pr0methean
Copy link
Member

Pr0methean commented May 16, 2024

Fixing this will require that ZipError::InvalidArchive wrap a Cow<'static, str> rather than &'static str so that it can include a message generated at runtime, but without the overhead of allocating a string at runtime when it's not doing so.

@Pr0methean
Copy link
Member

Started work on a solution, but running into some macro errors that I either don't know or have forgotten how to solve.

@Pr0methean Pr0methean added the help wanted Extra attention is needed label May 16, 2024
@Rapptz
Copy link

Rapptz commented Aug 2, 2024

I ran into this issue as well. I'd really like to know what the duplicate is or how to avoid this.

Started work on a solution, but running into some macro errors that I either don't know or have forgotten how to solve.

I think the error you're getting is because you're expanding the argument list into a tuple rather than just letting it expand as arguments to the format! macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants