Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LookupAllNameservers to look up all name servers at all levels, not just the top-most level #362

Open
phillip-stephens opened this issue May 17, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@phillip-stephens
Copy link
Contributor

phillip-stephens commented May 17, 2024

The current code performs an NS lookup against a name server for a given domain, d. With this list of name servers, it then sends a single lookup to each one. This works fine if there's only one layer of name servers, but this is not always the case.

Consider trying to query for an A record for google.com to a root server. The root server would provide a list of .com gTLD servers and we'd query each one for google.com's A record. None would have it, and so we'd exit.

IMO, we should change this function to get all name servers at all levels of recursion and query them all. So in the prior example, we'd continue to query all .com gTLD servers for the NS for google.com until we reached the authoritative name servers. We could then query all of these for the A record.

That or we should remove --all-nameservers as a CLI option since it's misleading, IMO.

@phillip-stephens phillip-stephens self-assigned this May 17, 2024
@zakird zakird added this to the Version 1.2 milestone Jun 1, 2024
@zakird zakird modified the milestones: Version 2.2, Version 2.0 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants