Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/variants.html #26

Open
bwbohl opened this issue Mar 24, 2014 · 1 comment
Open

test/variants.html #26

bwbohl opened this issue Mar 24, 2014 · 1 comment

Comments

@bwbohl
Copy link

bwbohl commented Mar 24, 2014

variants test fails in my local copy running through grunt run both in:
firefox:
TypeError: MeiLib.VariantMEI is undefined
file:///C:/Users/bwb/Documents/GitHub/MEItoVexFlow/tests/variants.html
Line 60

and
Chrome:
Uncaught TypeError: Cannot call method 'parseAPPs' of undefined variants.html:60
(anonymous function) variants.html:60
j jquery.js:3047
k.fireWith jquery.js:3159
o.extend.ready jquery.js:3365
I

@zolaemil
Copy link
Owner

We don't need this test anymore. (It fails because the latest major refactoring of meilib.js introduced non-backward compatible changes) This is basically a functional test for the meilib.js variant handling functions, but I think as long as we have unit test for all the functions, we don't really need such a test.

zolaemil pushed a commit that referenced this issue May 2, 2014
zolaemil pushed a commit that referenced this issue May 2, 2014
zolaemil pushed a commit that referenced this issue Jun 30, 2014
Moved vexflow and raphael dependencies (issue #26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants