Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If last staff is shorter in duration than other staves, music beyond that duration is lost from other staves #42

Open
mjwalter opened this issue Aug 29, 2014 · 4 comments

Comments

@mjwalter
Copy link

A test case is in my forked repository as TC-blank2.xml.

Staves with empty <layer> elements render fine. However, if such a staff is the last staff in the system, all staves appear blank.

The test case demonstrates this behaviour: the first measure has an extra (fifth) staff, and the parts render well, but in the second measure, the empty <layer> is the last staff, and therefore triggers the bug. If this layer is filled, the problem disappears.

(I would appreciate if you could point me to the problematic section of the code so I can try my hand at it myself!)

@zolaemil
Copy link
Owner

not sure, why... if you think it's a meitovexflow issue, I suggest debugging it with a m2v test case. Perhaps a bug in the selection of staves when slicing (meilib slicing methods)? you can find tests for that in test_meilib.html (actual tests implemented in runtest_meilib.js)

@mjwalter
Copy link
Author

Can you think of anything which relies on the last staff only for information? I'm thinking that the duration of the whole measure is calculated by looking at the last staff.

@mjwalter mjwalter changed the title If last staff has empty layer, all staves appear empty If last staff is shorter in duration than other staves, music beyond that duration is lost from other staves Aug 29, 2014
@zolaemil
Copy link
Owner

zolaemil commented Sep 3, 2014

Voices must have the same duration in order to achieve correct alignment.

@mjwalter
Copy link
Author

mjwalter commented Sep 3, 2014

But an empty layer shouldn't wipe out the material in the other staves. The music renders perfectly well if the blank staff is not the last. Instead of basing the duration of a measure on the values found in the last staff, it would be better to look at the duration of the longest staff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants