From ef6d1189d5fa470f65e5d82668415289c06a0c12 Mon Sep 17 00:00:00 2001
From: Jim O'Donnell <james.odonnell@dtc.ox.ac.uk>
Date: Fri, 25 Oct 2024 15:36:31 +0100
Subject: [PATCH] fix the subject picker tests

---
 .../SubjectPicker/SubjectPicker.spec.js       | 24 ++++++++++++-------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/packages/app-project/src/shared/components/SubjectPicker/SubjectPicker.spec.js b/packages/app-project/src/shared/components/SubjectPicker/SubjectPicker.spec.js
index ff197fd9ab..1695f34cff 100644
--- a/packages/app-project/src/shared/components/SubjectPicker/SubjectPicker.spec.js
+++ b/packages/app-project/src/shared/components/SubjectPicker/SubjectPicker.spec.js
@@ -10,6 +10,16 @@ describe('Components > Subject Picker', function () {
   let columnHeadings, displayName, link, tableRows
 
   before(async function () {
+    nock('https://panoptes-staging.zooniverse.org')
+      .get('/api/subjects/selection')
+      .query(true)
+      .reply(200, {
+        subjects: [
+          { id: 1, already_seen: false, retired: false },
+          { id: 2, already_seen: true, retired: false },
+          { id: 3, already_seen: true, retired: true }
+        ]
+      })
     const DefaultStory = composeStory(Default, Meta)
     await applyRequestHandlers(DefaultStory.parameters.msw)
     render(<DefaultStory />)
@@ -21,15 +31,11 @@ describe('Components > Subject Picker', function () {
       name: 'subject_id date FormSearch page FormSearch status'
     })
     const subjects = [
-      '23 January 1916',
-      '24 January 1916',
-      '25 January 1916'
+      '1 23 January 1916 43 SubjectPicker.unclassified',
+      '2 24 January 1916 44 SubjectPicker.alreadySeen',
+      '3 25 January 1916 45 SubjectPicker.retired'
     ]
-    tableRows = []
-    subjects.forEach(async subject => {
-      const row = await within(tableContent).findByText(subject)
-      tableRows.push(row)
-    })
+    tableRows = subjects.map(async subject => await within(tableContent).findByRole('row', { name: subject }))
     await Promise.all(tableRows)
   })
 
@@ -41,7 +47,7 @@ describe('Components > Subject Picker', function () {
     expect(columnHeadings).to.exist()
   })
 
-  it.skip('should have a row for each subject', function () {
+  it('should have a row for each subject', function () {
     expect(tableRows.length).to.equal(3)
   })