lib-classifier: Refactor survey task Choice styling #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbouslog
commented
Nov 19, 2024
Comment on lines
+61
to
+78
| const InfoLabel = ( | ||
| <Box | ||
| direction='row' | ||
| gap='xsmall' | ||
| > | ||
| {showInfo ? ( | ||
| <> | ||
| <Text>{t('SurveyTask.Choice.lessInfo')}</Text> | ||
| <FormUp /> | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <Text>{t('SurveyTask.Choice.moreInfo')}</Text> | ||
| <FormDown /> | ||
| </> | ||
| )} | ||
| </Box> | ||
| ) |
There was a problem hiding this comment.
The text and icon alignment isn't quite right, needs a little adjustment.
mcbouslog
commented
Nov 19, 2024
Comment on lines
+190
to
+194
| <StyledButton | ||
| fill='horizontal' | ||
| label={t('SurveyTask.Choice.cancel')} | ||
| onClick={() => handleDelete(choiceId)} | ||
| /> |
There was a problem hiding this comment.
Previously, if a previously selected choice was selected again, then "Not this" deleted that choice selection. Should "Cancel" still have the same delete choice selection action for previously selected choices?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package
Linked Issue and/or Talk Post
Describe your changes
How to Review
Helpful explanations that will make your reviewer happy:
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Refactoring
Post-merge