Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page content doesn't load if client-side JS fails #6344

Open
eatyourgreens opened this issue Sep 27, 2024 · 2 comments
Open

Home page content doesn't load if client-side JS fails #6344

eatyourgreens opened this issue Sep 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

Package

  • app-root

Describe the bug

If client-side JS fails, the new home page is a loading spinner, which runs forever.

The new About pages, which are rendered on the server, do show static content.

Screen.Recording.2024-09-27.at.11.07.36.mov

To Reproduce

Either disable JS, or block one of the home page bundles from loading, then visit the home page.

Alternatively, use dev tools to throttle your connection to a very slow speed.

Expected behavior

Static content, like the list of blog posts, should at least load, even if JS is required to log in and fetch recent projects, classifications, etc.

Additional context

Client-side JS will fail for ~1% of any site's visitors. I think I had a slide about this in one of my old Zoominar presentations. It's best practice to show some static HTML & CSS content, even when JS is disabled.

@eatyourgreens eatyourgreens added the bug Something isn't working label Sep 27, 2024
@eatyourgreens
Copy link
Contributor Author

Projects show static HTML and CSS if JS fails, though you do lose the ability to log in or classify.

Screen.Recording.2024-09-27.at.15.36.24.mov

@eatyourgreens
Copy link
Contributor Author

GDS: Building a robust front-end with progressive enhancement (27 Sept. 2024.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant