Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "stream" or "channel" based on server version #5827

Closed
alya opened this issue Feb 28, 2024 · 0 comments · Fixed by #5830
Closed

Use "stream" or "channel" based on server version #5827

alya opened this issue Feb 28, 2024 · 0 comments · Fixed by #5830
Assignees
@chrisbobbe
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented Feb 28, 2024 •
edited by chrisbobbe
Loading

In zulip/zulip#28468, we plan to rename "stream" to "channel" in the Zulip UI.

Ideally, the mobile apps will use the same terminology as the web app on the server version that the user is on.

Related issues:
@alya alya added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Feb 28, 2024
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Mar 5, 2024
@chrisbobbe
WIP ui: Use "channel" or "stream" based on server feature level
deb6019 
TODO:
- use the right feature level
- write appropriate TODO(server-x) comments
- run tools/tx-sync

Done at the level of TranslationProvider, which (conveniently) can
access the feature level of the active account if any.

The messages_en.json changes were done with a handy Perl one-liner
that Greg helped me work out:

perl -i -ne 'print; print if (s/stream/channel/g || s/Stream/Channel/g)' static/translations/messages_en.json

Fixes: zulip#5827
@chrisbobbe chrisbobbe mentioned this issue Mar 5, 2024
Merged
@gnprice gnprice mentioned this issue Mar 6, 2024
Closed
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Mar 6, 2024
@chrisbobbe
WIP ui: Use "channel" or "stream" based on server feature level
1dfc3e7 
TODO:
- use the right feature level
- Make sure servers at that feature level accept `@channel` for
  wildcard mentions. Discussion:
    https://chat.zulip.org/#narrow/stream/378-api-design/topic/stream.2Fchannel.20rename.3A.20.40stream.20wildcard.20mention/near/1752545
- write appropriate TODO(server-x) comments
- run tools/tx-sync

Done at the level of TranslationProvider, which (conveniently) can
access the feature level of the active account if any.

The messages_en.json changes were done with a handy Perl command
that Greg helped me work out:

$ perl -i -ne '
      print;
      print if (s/stream/channel/g || s/Stream/Channel/g);
    ' static/translations/messages_en.json

Fixes: zulip#5827
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Mar 7, 2024
@chrisbobbe
WIP ui: Use "channel" or "stream" based on server feature level
51e1370 
TODO:
- use the right feature level
- Make sure servers at that feature level accept `@channel` for
  wildcard mentions. Discussion:
    https://chat.zulip.org/#narrow/stream/378-api-design/topic/stream.2Fchannel.20rename.3A.20.40stream.20wildcard.20mention/near/1752545
- write appropriate TODO(server-x) comments
- run tools/tx-sync
- address TODO(zulip#5827) in tools/check-messages-en

Done at the level of TranslationProvider, which (conveniently) can
access the feature level of the active account if any.

The messages_en.json changes were done with a handy Perl command
that Greg helped me work out:

$ perl -i -ne '
      print;
      print if (s/stream/channel/g || s/Stream/Channel/g);
    ' static/translations/messages_en.json

Fixes: zulip#5827
This was referenced Apr 23, 2024
Closed
Open
@gnprice gnprice mentioned this issue Apr 24, 2024
Closed
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 26, 2024
@chrisbobbe
ui: Use "channel" or "stream" based on server feature level
a5ed7dc 
Done at the level of TranslationProvider, which (conveniently) can
access the feature level of the active account if any.

Fixes: zulip#5827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
Zulip release priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Use "channel" or "stream" based on server feature level chrisbobbe/zulip-mobile
2 participants
@alya @chrisbobbe