Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There isn't any props to disable ion-ripple-effect #465

Open
alfredarcifa opened this issue Mar 2, 2021 · 6 comments
Open

There isn't any props to disable ion-ripple-effect #465

alfredarcifa opened this issue Mar 2, 2021 · 6 comments

Comments

@alfredarcifa
Copy link

alfredarcifa commented Mar 2, 2021

In documentation and in props I can't see any reference to disable the ripple effect.
In the render of the super-tab-button.component I see

render() {
        return (h(Host, { role: "button", "aria-label": this.label ? this.label.innerText : false, "aria-disabled": this.disabled ? 'true' : false, "aria-selected": this.active ? 'true' : 'false', class: {
                'ion-activatable': !this.disabled,
                'ion-focusable': !this.disabled,
                'icon-only': !!this.icon && !this.label,
                'label-only': !!this.label && !this.icon,
                active: Boolean(this.active),
                scrollableContainer: this.scrollableContainer,
            } },
            h("slot", null),
            h("ion-ripple-effect", { type: "unbounded" })));
    }
@alfredarcifa alfredarcifa changed the title There isn't any props to disable ion-ripple There isn't any props to disable ion-ripple-effect Mar 2, 2021
@ihadeed
Copy link
Member

ihadeed commented Mar 4, 2021

You can't disable it at the moment. Possibly doable with CSS though, you can try force hiding the ripple component.

Will add an option to disable it in later versions

@alfredarcifa
Copy link
Author

So, @ihadeed, there is only a solution with "bad practice" in CSS (forcing ::part(..) with not fully compatibility) .
With CSS vars there isn't any solution.

@Avalfr3d
Copy link

@ihadeed I'll wait for an option to disable ripple-effect.

It's important for me, thanks.

@anydeer
Copy link

anydeer commented May 19, 2021

Any update of this?

@alfredarcifa
Copy link
Author

@DEER90 fix in css

super-tab-button.ion-activatable { color: transparent !important }

I'll wait for params in components.

@anydeer
Copy link

anydeer commented Jun 17, 2021

@alfredarcifa params would be nice but your fix is also satisfying :) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants