File as parameter (Issue #11) #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI behaviour has changed slightly: flags cannot be passed after `action`. Updated tests accordingly.
Use custom argparse Action (FileInputAction) to open given file (or stdin if file is "-" or not given). Update usage and help messages and README examples. Issue 0k#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #11 and #13, added a new CLI option (
--file) to read from a file instead of just standard input.Personally, I would prefer it as a positional argument but i think it will conflict with the current interface.
In order to do it in a more "elegant" way, I have refactored the argument parsing to use python standard library's
argparsemodule.Then, added the new option which defaults to read from stdin and accepts a filename as value (and "-" as another way to read from stdin). Error handling for non-existing input file should probably be added.
Migrating to
argparsecauses an error for previously valid argument ordering. E.g., the following call is no longer valid:the valid call would be (notice the
y-flag position):