style: improve UserControls design #1324
Open
+419
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update dismiss button style and controls improve spacing improve brushes improve glyphs improve high contrast theme add design-time attributes format xaml
United600
force-pushed
the
controls
branch
3 times, most recently
from
87f1f67
to
75b963b
Compare
United600
changed the title
add ToggleReplaceModeButton animation
|
@United600 I have played around with latest WinUI3/WinAppSdk and decided to adopt the design and app model once its get matured. So far, there are still lots of issues presented（I have spent 30+ hours building an app using WinAppSDK so I know what I am speaking. NativeAOT support is also just realized by most of the parties. Guess we still need to wait for some time before taking any major actions. FYI: Your changes will be obsolete once we move to settings card controls etc when adopting WinUI3. |
|
That's sad to hear. Personally, I would have opted for WinUI 2 first and stuck with UWP in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the look and visual states of the
DismissButtonStyle(renamed toTransparentButtonStyle) and the respective UserControls that make use of it.PR Type
Find and Replace
ToggleReplaceModeButtontouch targetToggleReplaceModeButtonanimationFindAndReplace.mp4
GoTo
GoTo.mp4
SideBySideDiffViewer
DismissButtonsizeSidebySideDiff.mp4
Other information
Adds some design attributes and better XAML formatting.