-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle "read only" attribute to modify read only file or lock modification to file #636
base: master
Are you sure you want to change the base?
Conversation
@Jasonstein Notepad++ doesn't allow editing readonly files by default, but after removing readonly flag it allows editing and user than can save the file. Should we implement this behavior?? Or, should we prompt user when trying to save a readonly file and if user accepts remove the readonly attribute?? |
@Jasonstein this is the behavior I have come up with for editing normal vs read-only files:
|
Two cents:
Btw, how could you import those win32 dlls? Will they work in production? What about future compatibility with Windows 10x? |
Will do that.
Wouldn't displaying notification be too intrusive?? Currently I am showing the modified icon in the tab in grey/disabled color when file is read only.
..FromApp methods are made with uwp security model so they will work in production and there won't be any future incompatibility. |
What about the file that user dragged into notepads? (They are read-only to notepads but they do not have read-only attribute) |
They would work like normal files. None of the |
@Jasonstein I have modified the behavior as you said:
|
This pr aims to implement modifying files with readonly attribute.
PR Type
What kind of change does this PR introduce?
Other information
While Windows Notepad doesn't allow modifying files with readonly attribute, Notepad++ allows editing them once this flag is removed.