Update to OP stack v1.3.0 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroduce more documentation
The major change is that the L1 genesis now includes the L2 contracts in the genesis itself. This requires retooling the deploy logic to handle two scenarios: either deploy to a temporary geth, or to a real L1. The deploy logic was moved to `l2_deploy.py`. The deploy config generation logic, which is now also necessary for generating the L1 genesis, was moved to `deploy_config.py`.
Global clean now removes the deploy config, but clean-l1 and clean-l2 don't clean-build now cleans the account-abstraction repo as well. Global clean now cleans the explorer and account-abstractions if they're requested as arguments.
…f we don't have the correct tag
…nents on the same machine to reach each others via localhost if possible Also, the websocket connection to the L1 works now!
…d) and add upnode config
|
Deployment to Goerli works with the "dev" preset, but with the "prod" preset, the proposer never submits anything, even after running for ~20 minutes and the batcher posting batches to blocks that have been finalized for a while. The max channel size is also 1, so that should be an issue. I suspect that if I rerun with the same config but just changing Maybe the "basic RPC kind" (a config option) fails to properly convey the finalization status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #65, #21, #56
also #29, partially
The major change is that the L1 genesis now includes the L2 contracts in the
genesis itself.
This requires retooling the deploy logic to handle two scenarios: either deploy
to a temporary geth, or to a real L1.
The deploy logic was moved to
l2_deploy.py.The deploy config generation logic, which is now also necessary for generating
the L1 genesis, was moved to
deploy_config.py.Additionally, this PR retools the RPC address handling, to be able to isolate the various URL components (host, port, protocol and also a path part that is necessary to deal with external JSON-RPC providers like alchemy).
Right now I have a protocol/host/port variable per RPC URL, but in a future PR I want to replace that with the data class I've introduced to reduce the number of variables in the config.
I also fixed a few things left and right that are not super noteworthy right now.
Not merging this yet, I want to try a "prod" deployment first, and also split up the remote endpoints in the config so that this is easier to merge with #66