-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting: gov module #7
Changes from 50 commits
20c7bab
5fabe14
6ae10dc
2529319
e1a6c2f
246fce5
f159c6d
ae5a857
8d85eb1
0dc2578
f53183e
705b5e8
4010477
1b93e32
ae2226d
ae826fb
36d79e4
8ea74f0
89cac52
c92a5e0
e85fe55
c793367
d4fc81d
28f9940
756fcf2
9b9609a
ba0eac3
2031f34
3ecf8d5
069cbf0
f00a504
d6ffea2
d22489d
7ca5b40
3b03e87
8a1af2d
90360da
4abf435
13af779
e2011fb
f126f22
72ea82b
9f8955c
39fd8a9
0223595
21f52a1
a3097b1
efc6cf5
3f551ab
ec29c6e
f72216e
268611f
942d844
39dd6b9
1d959cc
e2147a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -545,7 +545,8 @@ func (s *E2ETestSuite) TestNewCmdWeightedVote() { | |
for _, tc := range testCases { | ||
tc := tc | ||
s.Run(tc.name, func() { | ||
cmd := cli.NewCmdWeightedVote() | ||
// TODO HV2: changed from NewCmdWeightedVote to NewCmdVote. Fix tests accordingly. | ||
cmd := cli.NewCmdVote() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if weighted voting is not supported in Heimdall, would it nevertheless be simpler to leave this as This would also apply to file There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, I agree. Changed it in the very beginning with the purpose of implementing some tests, but both are actually covered in the vanilla SDK. Reverted here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved |
||
clientCtx := val.ClientCtx | ||
var txResp sdk.TxResponse | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should this be a TODO comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, pushed with commit 1d959cc, thanks