Add Certora spec files #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the contracts have specs written for them, expect PoWUtil.sol becasue of timeouts
web3security
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
This is great, thanks a lot @dev1644 , just few comments as suggestions.
certora/specs/PowUtil.spec
Outdated
| uint256 a; | ||
| uint256 b; | ||
|
|
||
| require a >= 10 ^ 18; |
There was a problem hiding this comment.
I would suggest we use a > =1,352,243,068 or a >= 1352 * 10^6 instead of a >= 10 ^18 due to exp2 function gets as input (INTEREST_PER_YEAR_LOG2 * timeElapsed) / 365 days)
certora/specs/PowUtil.spec
Outdated
| rule resultShouldAlwaysbeGEThanOne(env e) { | ||
| uint256 a; | ||
|
|
||
| require a >= 10 ^ 18; |
certora/specs/PowUtil.spec
Outdated
| rule resultShouldNotBeZero(env e) { | ||
| uint256 a; | ||
|
|
||
| require a >= 10 ^ 18; |
Hey @web3security , I will add the changes as you suggested, but just note as I mentioned earlier, |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.