-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use drag & drop to select and replace an image in the Image component #218
base: develop
Are you sure you want to change the base?
Conversation
Size Change: +72 B (0%) Total Size: 52.3 kB
|
@fabiankaegy the functionality works without error but fails within the E2E context. I've tried debugging and got this error: Would you have any clue about this? |
@Sidsector9 Yeah, I've also seen that issue unrelated to this PR. But I've not yet been able to figure out what the cause for that actually is :( |
:( I'll spend some time this week to investigate further. I'll open this PR for review. |
@Sidsector9 Thank you for working on this :) I noticed one small regression: The Focal point picker now renders when no image is present, which should not be the case. I'm also still a little unsure how to best go about the image markup. It causes some issues that we have to introduce the additional DIV in the markup since many usages of this component rely on the image being a direct descendant of a figure element for example... We are running into the same issue here: #172 I'm not sure we have a better solution though. Just throwing it out there. |
@fabiankaegy The console error originates from WP Core only when the Block Inserter (the one on the top left of the editor) is used. This happens as the patterns start to load. I did not dig into Core to investigate further, I instead used an alternative way to resolve it. The solution is related to 10up/cypress-wp-utils#96 See the video below: Screen-2023-06-11-211409.mp4-- As for the regression with the focal point picker, that is resolved.
That makes sense. On a high level #222 describes good solutions, I'll dig further and respond if I can think of any more solutions. |
Description of the Change
Adds ability to drag and replace the image in the Image Component
Closes #165
Screencast
Screen.Recording.2023-05-29.at.1.24.42.PM.mov
How to test the Change
Changelog Entry
Credits
Props @fabiankaegy @Sidsector9
Checklist: