-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: IconPicker TypeScript Conversion #321
Feature: IconPicker TypeScript Conversion #321
Conversation
Size Change: -48 B (-0.07%) Total Size: 65 kB
|
Passing run #846 ↗︎
Details:
Review all test suite changes for PR #321 ↗︎ |
@fabiankaegy even though tests are passing I see a lot of things on the Cypress run. While there are things that look unrelated, the related ones are odd. I based the code on what was there but those type checking might be coming from WP code or something (see |
@Antonio-Laguna yeah currently the I will review this in a bit :) Thanks for your help <3 |
@Antonio-Laguna testing this locally I am seeing the following error when trying to add
|
# Conflicts: # example/src/blocks/icon-picker-example/edit.tsx
@fabiankaegy solved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great :) Thanks!
Description of the Change
This migrates the IconPicker to TypeScript and also removes
defaultProps
from it.Relates to #295 and #314
How to test the Change
Changelog Entry
Checklist: