Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: IconPicker TypeScript Conversion #321

Merged
merged 8 commits into from
May 20, 2024

Conversation

Antonio-Laguna
Copy link
Member

Description of the Change

This migrates the IconPicker to TypeScript and also removes defaultProps from it.

Relates to #295 and #314

How to test the Change

Changelog Entry

Changed - Moved IconPicker to TypeScript

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

github-actions bot commented May 13, 2024

Size Change: -48 B (-0.07%)

Total Size: 65 kB

Filename Size Change
dist/index.js 65 kB -48 B (-0.07%)

compressed-size-action

Copy link

cypress bot commented May 13, 2024

Passing run #846 ↗︎

0 6 0 0 Flakiness 0

Details:

Solidifying types
Project: 10up Block Components Commit: 93138c769c
Status: Passed Duration: 01:25 💡
Started: May 20, 2024 3:22 PM Ended: May 20, 2024 3:24 PM

Review all test suite changes for PR #321 ↗︎

@Antonio-Laguna Antonio-Laguna marked this pull request as ready for review May 13, 2024 07:53
@Antonio-Laguna
Copy link
Member Author

@fabiankaegy even though tests are passing I see a lot of things on the Cypress run. While there are things that look unrelated, the related ones are odd. I based the code on what was there but those type checking might be coming from WP code or something (see dashicons mention)

@fabiankaegy
Copy link
Member

@Antonio-Laguna yeah currently the npm run build command spits out thousands of errors because the types are still very rough and incomplete.

I will review this in a bit :) Thanks for your help <3

@fabiankaegy
Copy link
Member

@Antonio-Laguna testing this locally I am seeing the following error when trying to add className to the <InlineIconPicker

CleanShot 2024-05-15 at 11 28 46@2x

<InlineIconPicker value={icon} onChange={handleIconSelection} className="icon-preview"/>

# Conflicts:
#	example/src/blocks/icon-picker-example/edit.tsx
@Antonio-Laguna
Copy link
Member Author

@fabiankaegy solved :)

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great :) Thanks!

@fabiankaegy fabiankaegy merged commit a2d8101 into develop May 20, 2024
7 of 8 checks passed
@fabiankaegy fabiankaegy deleted the feature/icon-picker-typescript-conversion branch May 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants