Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Optional component code example #350

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

barryceelen
Copy link
Member

Description of the Change

Add import declaration for the Optional component to the readme.md example.

Copy link

github-actions bot commented Dec 3, 2024

Size Change: 0 B

Total Size: 63.9 kB

ℹ️ View Unchanged
Filename Size
dist/index.js 63.9 kB

compressed-size-action

Copy link

cypress bot commented Dec 3, 2024

10up Block Components    Run #942

Run Properties:  status check failed Failed #942  •  git commit ecdee1f472: Update optional component example
Project 10up Block Components
Branch Review feature/update-optional-component-readme
Run status status check failed Failed #942
Run duration 06m 46s
Commit git commit ecdee1f472: Update optional component example
Committer Barry Ceelen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 32
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Tests for review

Failed  ColorSettings.spec.js • 5 failed tests

View Output

Test Artifacts
ColorSettings > Allows the user to pick the block and displays it Test Replay Screenshots
ColorSettings > Allows the user to use a custom color and displays it Test Replay Screenshots
ColorSettings > Allows the user to clear the color Test Replay Screenshots
ColorSettings > Allows the user to add custom label and help text Test Replay Screenshots
ColorSettings > Allows the user to pick from predefined colors Test Replay Screenshots
Failed  Counter.spec.js • 6 failed tests

View Output

Test Artifacts
Counter > Allows the user to pick the block and displays it Test Replay Screenshots
Counter > Has the counter component in the block Test Replay Screenshots
Counter > Has the correct starting value Test Replay Screenshots
Counter > Updates the count appropriately Test Replay Screenshots
Counter > Updates to the approaching limit state appropriately Test Replay Screenshots
Counter > Updates to the is over limit state appropriately Test Replay Screenshots
Failed  IconPicker.spec.js • 1 failed test

View Output

Test Artifacts
IconPicker > allows the user to use the post picker to change an icon and displays it Test Replay Screenshots
Failed  Link.spec.js • 1 failed test

View Output

Test Artifacts
Link > allows the editor to pick a link directly inline Test Replay Screenshots
Failed  PostFeaturedImage.spec.js • 3 failed tests

View Output

Test Artifacts
PostFeaturedImage > Allows the user to pick the block and displays it Test Replay Screenshots
PostFeaturedImage > Allows the user to pick an image from the media library and displays it inline Test Replay Screenshots
PostFeaturedImage > Syncs with the post featured image Test Replay Screenshots

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

@fabiankaegy fabiankaegy merged commit ca173eb into develop Dec 3, 2024
5 of 8 checks passed
@fabiankaegy fabiankaegy deleted the feature/update-optional-component-readme branch December 3, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants