-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the embed default size for the case of Figma Embed blocks to allow supporting wide view using the native aspect ratio classes provided by the editor #9
Conversation
…llow supporting wide view using the native aspect ratio classes provided by the editor
5f43ef7
to
cd19081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing this, it doesn't seem to be working for me. Using the example Figma URL (https://www.figma.com/design/FdZULoLQWlOdxT606IHiyi/Bravo-sample%3A-Calendar-Picker-(Community)?node-id=0-1&t=L9HVeuyFCQTxTLoL-0), I never see the wp-has-aspect-ratio
class being added to that block, which appears that is needed to make the wide and full alignment work.
Note in testing with another example Figma link (https://www.figma.com/file/LKQ4FJ4bTnCSjedbRpk931/Sample-Files), I do see the alignment options working fine but they work fine on the develop
branch as well, so seems like the fix in this PR is only needed for certain Figma files.
Hello @dkotter. I can't understand why it doesn't work for you. Have you used the working branch of this PR and built the assets? Here is a recording with the first Figma link that you posted Edit-Page-.Figma-block.-.-opensource-test-.-WordPress.1.mp4and another recording with the second link that you posted Edit-Page-.Figma-block.-.-opensource-test-.-WordPress.mp4As you can see, for both cases the Do you have any idea what might be missing or going wrong on your end? Thank you |
Just tested again and am seeing the same thing. Wondering if this is theme dependent? Curious what theme you're testing with and if any other plugins are active? |
Hello @dkotter I use the following
Regarding theme, I've verified this behavior with more than one free theme but now I can't remember which ones I've used. |
Tested again by deleting the embed blocks that weren't working and adding those back and they do have the proper classes now. Not sure why it didn't work the first few times I tested but just going to assume it was an issue on my end. Thanks for the work here! |
Description of the Change
In this PR I'm modifying the embed default size for the case of Figma Embed blocks to allow supporting wide view using the native aspect ratio classes provided by the editor
Closes #2
How to test the Change
Wide
to make sure that block occupies the full width of the pageChangelog Entry
Credits
Props @kmgalanakis
Checklist: