macOS: switch to png for image #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gae24
force-pushed
the
mac-png
branch
4 times, most recently
from
3203d92
to
c283f81
Compare
|
Hey there, thanks for the PR. Similar to the first PR which tried this, can I ask that you do some basic compatibility testing to make sure this doesn't regress any major use cases? Some examples would be:
|
complexspaces
requested changes
Oct 19, 2024
|
Unfortunately at the moment I don't have access to an Apple device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used png for handling images on all platform. On macOS dropped the dependency on core-graphics since now an image is directly stored as png