Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a dummy clipboard to fix building for unsupported platforms. #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yeicor
Copy link

@Yeicor Yeicor commented May 26, 2022

No description provided.

@complexspaces
Copy link
Collaborator

Hey there, thanks for the PR.

Would you be able to explain your use case for this? The intention currently is that users of arboard handle these platform availability differences in their own code.

It feels like if we merged this, it could very well lead to more confusion for users (or those looking) because the crate would compile for them, but only result in errors. This could also lead to annoyance. In my opinion, if an entire crate can't provide any functionality for a target, it probably should not compile for it.

@Yeicor
Copy link
Author

Yeicor commented Jun 12, 2022

My issue was that my project had a transitive dependency that optionally enables the arboard feature, but it does so by default and I have no way to change it (without also patching it). I wanted to build my project for android but this arboard dependency, which I do not use at all, was one of the errors.

The fork that I made was enough to build my project for android, using the patch section on Cargo.toml. Hence, I have no need for this to actually be merged, but I thought that other users in the same situation may want this. I also get why the fail approach of not compiling for an unsupported platform may avoid confusion and how, apart from transitive dependencies, this may be fixed from the user code. Feel free to close the PR if you think it doesn't fit the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants