Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-facing test cases and example code #3

Merged
merged 33 commits into from
Mar 12, 2024
Merged

User-facing test cases and example code #3

merged 33 commits into from
Mar 12, 2024

Conversation

sam-1pass
Copy link
Contributor

Test cases for Client class, resolve, and new_default_config functions inside src/tests/test_python.py.
Also an example snippet inside examples/example.py.

@sam-1pass sam-1pass requested a review from Marton6 February 15, 2024 14:36
@sam-1pass sam-1pass self-assigned this Feb 15, 2024
Marton6
Marton6 reviewed Feb 15, 2024
View reviewed changes
examples/example.py Outdated Show resolved Hide resolved
examples/example.py Outdated Show resolved Hide resolved
src/tests/test_client.py Outdated Show resolved Hide resolved
src/tests/test_client.py Outdated Show resolved Hide resolved
src/tests/test_client.py Outdated Show resolved Hide resolved
Marton6
Marton6 reviewed Feb 15, 2024
View reviewed changes
src/tests/test_client.py Outdated Show resolved Hide resolved
Marton6
Marton6 reviewed Feb 26, 2024
View reviewed changes
src/tests/test_client.py Outdated Show resolved Hide resolved
volodymyrZotov
volodymyrZotov reviewed Mar 7, 2024
View reviewed changes
src/onepassword/client.py Outdated Show resolved Hide resolved
src/onepassword/client.py Show resolved Hide resolved
src/onepassword/client.py Outdated Show resolved Hide resolved
src/onepassword/example.py Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Mar 11, 2024
View reviewed changes
src/onepassword/client.py Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Mar 11, 2024
View reviewed changes
src/onepassword/client.py Outdated Show resolved Hide resolved
libutcher
libutcher reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@libutcher libutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent! I just left some minor notes and questions for the code comments. I'll draft the Readme in a separate PR later today. Let me know when you've had a chance to look through these comments and I'll take a second look and approve.

src/onepassword/client.py Outdated Show resolved Hide resolved
src/onepassword/core.py Outdated Show resolved Hide resolved
src/onepassword/core.py Outdated Show resolved Hide resolved
src/onepassword/example.py Outdated Show resolved Hide resolved
src/onepassword/example.py Outdated Show resolved Hide resolved
src/onepassword/example.py Outdated Show resolved Hide resolved
.github/workflows/validate.yml Outdated Show resolved Hide resolved
AndyTitu
AndyTitu approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. To be merged after Lucy's comments are resolved

@sam-1pass sam-1pass merged commit fb32432 into main Mar 12, 2024
2 checks passed
@AndyTitu AndyTitu deleted the sam/tests branch July 31, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libutcher libutcher libutcher left review comments

@AndyTitu AndyTitu AndyTitu approved these changes

@volodymyrZotov volodymyrZotov volodymyrZotov left review comments

@Marton6 Marton6 Marton6 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-1pass @Marton6 @volodymyrZotov @AndyTitu @libutcher