Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1103] add cheapEthSender #134

Merged
merged 5 commits into from
Apr 2, 2024
Merged

[SC-1103] add cheapEthSender #134

merged 5 commits into from
Apr 2, 2024

Conversation

SevenSwen
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (98259b2) to head (217d34b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   93.15%   93.23%   +0.08%     
==========================================
  Files          16       17       +1     
  Lines         336      340       +4     
  Branches       66       66              
==========================================
+ Hits          313      317       +4     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zZoMROT
Copy link
Contributor

zZoMROT commented Mar 28, 2024

I'd like to suggest not to forget about adding the NatSpec comments and refreshing the documentation using the command:

yarn docify

@ZumZoom
Copy link
Member

ZumZoom commented Apr 2, 2024

Classic transfer

9000 (positive_value_cost) + 2600 (cold_address_access_cost) - 2300 (call_stipend) + ?? (execution_cost) ~= 9300

Selfdestruct transfer

5000 (selfdestruct_cost) + 2600 (cold_address_access_cost) = 7600

Diff

9300 - 7600 = 1700

Actual diff

1778

@ZumZoom ZumZoom merged commit ef05c02 into master Apr 2, 2024
8 checks passed
@ZumZoom ZumZoom deleted the feature/cheaperEthSend branch April 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants